X Tutup
Skip to content

Remove a dead code (font_manager.ttfdict_fnames)#7929

Merged
NelleV merged 1 commit intomatplotlib:masterfrom
kshramt:deadcode_fm
Jan 24, 2017
Merged

Remove a dead code (font_manager.ttfdict_fnames)#7929
NelleV merged 1 commit intomatplotlib:masterfrom
kshramt:deadcode_fm

Conversation

@kshramt
Copy link
Copy Markdown
Contributor

@kshramt kshramt commented Jan 23, 2017

No description provided.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 23, 2017

It appears you may have not set your git config email correctly; perhaps you wish it to be private, but I suggest using GitHub's email alias instead because then it will be a bit more unique.

@kshramt
Copy link
Copy Markdown
Contributor Author

kshramt commented Jan 23, 2017

Thank you for letting me know.
Following your instruction, I set Github's email alias.

@kshramt
Copy link
Copy Markdown
Contributor Author

kshramt commented Jan 23, 2017

I am not sure if the Travis failure is related to this change.

@NelleV
Copy link
Copy Markdown
Member

NelleV commented Jan 23, 2017

Even if the code is not used internally, it may be used elsewhere. We cannot remove a function without a proper deprecation warning. Can you add the function back, and deprecate it?

@kshramt
Copy link
Copy Markdown
Contributor Author

kshramt commented Jan 24, 2017

@NelleV Thank you for the comment.
I force pushed the fix.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 24, 2017

Another side bar: The private address uses users.noreply.github.com, not github.noreply.github.com.

@kshramt
Copy link
Copy Markdown
Contributor Author

kshramt commented Jan 24, 2017

Thanks, I fixed the address.

@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Jan 24, 2017

@QuLogic Out of curiosity, where can you see the committer email from the github interface?

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 24, 2017

@anntzer I don't, but there's a hint from the profile image next to the commit. It's the generic 'unknown author/committer' instead of @kshramt's. You have to fetch the pull commits to see the actual email.

@anntzer anntzer changed the title Remove a dead code (font_manager.ttfdict_fnames) [MRG+1] Remove a dead code (font_manager.ttfdict_fnames) Jan 24, 2017
@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Jan 24, 2017

Thanks.
LGTM.

@NelleV
Copy link
Copy Markdown
Member

NelleV commented Jan 24, 2017

Thanks @kshramt !

@NelleV NelleV merged commit 23b93bd into matplotlib:master Jan 24, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 24, 2017
@QuLogic QuLogic changed the title [MRG+1] Remove a dead code (font_manager.ttfdict_fnames) Remove a dead code (font_manager.ttfdict_fnames) Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup