Remove a dead code (font_manager.ttfdict_fnames)#7929
Remove a dead code (font_manager.ttfdict_fnames)#7929NelleV merged 1 commit intomatplotlib:masterfrom
font_manager.ttfdict_fnames)#7929Conversation
|
It appears you may have not set your git config email correctly; perhaps you wish it to be private, but I suggest using GitHub's email alias instead because then it will be a bit more unique. |
|
Thank you for letting me know. |
|
I am not sure if the Travis failure is related to this change. |
|
Even if the code is not used internally, it may be used elsewhere. We cannot remove a function without a proper deprecation warning. Can you add the function back, and deprecate it? |
|
@NelleV Thank you for the comment. |
|
Another side bar: The private address uses |
|
Thanks, I fixed the address. |
|
@QuLogic Out of curiosity, where can you see the committer email from the github interface? |
font_manager.ttfdict_fnames)font_manager.ttfdict_fnames)
|
Thanks. |
|
Thanks @kshramt ! |
font_manager.ttfdict_fnames)font_manager.ttfdict_fnames)
No description provided.