Convert test_s* files to pytest and flake8 them#7918
Merged
phobson merged 2 commits intomatplotlib:masterfrom Jan 23, 2017
Merged
Convert test_s* files to pytest and flake8 them#7918phobson merged 2 commits intomatplotlib:masterfrom
phobson merged 2 commits intomatplotlib:masterfrom
Conversation
NelleV
approved these changes
Jan 22, 2017
Member
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
LGTM
I wouldn't do too much clean up on files that are likely to be modified in other PRs, as this may yield conflicts quite annoying to resolve.
NelleV
changed the title
Current coverage is 62.18% (diff: 100%)@@ master #7918 diff @@
==========================================
Files 175 175
Lines 56125 56125
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 34901 34899 -2
- Misses 21224 21226 +2
Partials 0 0
|
phobson
approved these changes
Jan 23, 2017
phobson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be mostly flake8 in the end, but what's done is done now (though I could split the PRs if necessary.)