X Tutup
Skip to content

MAINT moved all remaining "f" modules to pytest#7897

Merged
jkseppan merged 2 commits intomatplotlib:masterfrom
NelleV:pytest_f_modules
Jan 23, 2017
Merged

MAINT moved all remaining "f" modules to pytest#7897
jkseppan merged 2 commits intomatplotlib:masterfrom
NelleV:pytest_f_modules

Conversation

@NelleV
Copy link
Copy Markdown
Member

@NelleV NelleV commented Jan 20, 2017

This PR migrates the modules starting by "f" from nosetests to pytest.
It also does minor flake8 clean ups.

Copy link
Copy Markdown
Member

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phobson phobson changed the title MAINT moved all remaining "f" modules to pytest [MRG+1] MAINT moved all remaining "f" modules to pytest Jan 21, 2017
@phobson phobson added this to the 2.1 (next point release) milestone Jan 22, 2017
unicode_literals)

import six
from six.moves import xrange
Copy link
Copy Markdown
Member

@QuLogic QuLogic Jan 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this xrange too, while you're cleaning up things; there's only one of them.

@codecov-io
Copy link
Copy Markdown

Current coverage is 62.18% (diff: 100%)

Merging #7897 into master will increase coverage by <.01%

@@             master      #7897   diff @@
==========================================
  Files           174        175     +1   
  Lines         56121      56125     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34896      34901     +5   
+ Misses        21225      21224     -1   
  Partials          0          0          

Powered by Codecov. Last update 194afed...3a96dbc

@jkseppan jkseppan changed the title [MRG+1] MAINT moved all remaining "f" modules to pytest MAINT moved all remaining "f" modules to pytest Jan 23, 2017
@jkseppan jkseppan merged commit 6bbf92c into matplotlib:master Jan 23, 2017
@NelleV NelleV deleted the pytest_f_modules branch January 29, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup