Convert remaining test_t* files to pytest.#7889
Merged
NelleV merged 2 commits intomatplotlib:masterfrom Jan 22, 2017
Merged
Conversation
Member
|
Looks good to me. |
jkseppan
changed the title
jkseppan
approved these changes
Jan 20, 2017
QuLogic
force-pushed
the
pytest-t-test
branch
from
114cc4c to
5429591
Compare
phobson
approved these changes
Jan 21, 2017
Member
phobson
left a comment
phobson
left a comment
There was a problem hiding this comment.
Looks great. Minor, non-blocking comments/questions included
| @@ -96,16 +97,21 @@ def test_delaunay_points_in_line(): | |||
|
|
|||
| def test_delaunay_insufficient_points(): | |||
Member
There was a problem hiding this comment.
Could this test be parametrized or are we not doing that yet?
| from matplotlib.testing.decorators import image_comparison, knownfailureif | ||
| import matplotlib.pyplot as plt | ||
| from nose.tools import assert_raises | ||
| from numpy.testing import assert_array_equal |
QuLogic
force-pushed
the
pytest-t-test
branch
from
5429591 to
f1748e8
Compare
Current coverage is 62.17% (diff: 100%)@@ master #7889 diff @@
==========================================
Files 174 174
Lines 56121 56121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34896 34896
Misses 21225 21225
Partials 0 0
|
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"remaining" meaning not covered by the other PRs.