Make radio and check buttons visible#7861
Conversation
dopplershift
left a comment
There was a problem hiding this comment.
The fix looks good. It would be good to add an image test to make sure this doesn't break in the future. If we had this before, 2.0 might not have broken it.
|
Fixes #7860. |
|
@dopplershift I haven't written an image comparison test before, but I guess it would mean:
Does that sound about right? |
|
That's it exactly. |
|
Thanks for the input, added an image comparison test. |
|
Since these are a) new tests and b) only broken on the new style, you will need to add Also, please amend the last commit so that we don't have an extra copy of the test images. |
|
@QuLogic Ah, gotcha. Didn't realize the |
|
btw, is there a way to display both sets of buttons (Radio and Check) and relocate them so they don't overlap? |
81f7c50 to
508bd68
Compare
Current coverage is 62.16% (diff: 100%)@@ master #7861 diff @@
==========================================
Files 174 174
Lines 56072 56072
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34831 34859 +28
+ Misses 21241 21213 -28
Partials 0 0
|
cbeb40d to
661e45d
Compare
531bf7e to
404ad92
Compare
|
There is some general test flakiness (connectivity?) but it looks unrelated to this PR. |
|
I have restarted the relevant tests but yes they look like network issues. Failing to install nose from github and failing some url based tests |
Do you mean on the same figure? Use different values for |
dopplershift
left a comment
There was a problem hiding this comment.
Great. Thanks for adding the tests!
|
Thanks - actually can you hold off on merge for one sec? Seeing if I can combine the tests into 1 test instead of 2. |
|
OK, I think this is good to merge now. Thanks! |
Make radio and check buttons visible
|
The backport of this seems to have broken CI somehow. |
|
|
|
Oh yes, you're right. Looks like it's just a merge error on backport then. Should be a bit easier to fix then. |
Fixes #7860.
Add


blackedge color to radio and check buttons so they are visible.