Merged
Conversation
By default, don't include tests in binary distributions.
Update to include details about how to re-enable.
Closes #7715 This ensures that on python2 the values passed into `check_output` or `Popen` are bytes. If they are passed in as unicode (due to unicode_literals at the top of most of our files) they will cause an exception when there is a path in PATH that has non-ascii values. The reason is that when locating possible executable our input (as unicode) is concatenated with the non-ascii path (as bytes) which then fails to encode as ascii and raises. The other two places we currently use `check_output` (setupext.py and tools/github_stats.py) we do not need this handling as we do not import unicode_iterals in those files.
Without this change, zooming in from ticks separated by days to ticks separated by multiples of hours leaves tick labels with no date information, even when the time period covers several days. With the change there is a systematic progression from one level to the next, dropping the largest unit and adding a smaller unit.
BUG: fix checkout_output with non-ascii paths in PATH
STY: fix poor date-time format defaults
Api doc backport no imag build
As part of scaling dashes with linewidth, unscaled versions of the dash pattern are now tracked. Make sure we copy these as well.
To prevent double-scaling of the pattern in the legend Closes #7814
Give correct name for toolkits_tests parameter to set in setup.cfg.
DOC: fix name of toolkit test in API doc
DOC: matplotlib -> Matplotlib
Fix collection legend handlers
Member
Author
|
I just realized that, as I pushed this here, I can just wait for the build on the branch. Therefore, I'm going to cancel the PR-related builds to free up CI a bit. |
Member
Author
|
Travis is good, so in it goes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a couple conflicts with
.travis.yml, so just run it to be sure it's merged correctly.