X Tutup
Skip to content

DOC: Changes to screenshots plots.#7821

Merged
NelleV merged 1 commit intomatplotlib:masterfrom
DietBru:remove_showcase_piechart
Jan 16, 2017
Merged

DOC: Changes to screenshots plots.#7821
NelleV merged 1 commit intomatplotlib:masterfrom
DietBru:remove_showcase_piechart

Conversation

@DietBru
Copy link
Copy Markdown
Contributor

@DietBru DietBru commented Jan 13, 2017 •
edited
Loading

Before:

simple_plot1_before

After:

simple_plot1_after

@NelleV As stated in #7740, I don't have strong preferences concerning doc/make.py. If it helps with your future work, I can restore the original behavior of utilizing static images for the front page plots (If you prefer to do that yourself in this pull request, feel free).

@DietBru
Made some changes to showcase plots plots.
8f3e013 
* removed ugly pie chart
* changed fontsize of labels in scatter plot
* changed y-range in sine plot to work around bounding box problem.
@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jan 13, 2017
@NelleV
Copy link
Copy Markdown
Member

NelleV commented Jan 13, 2017

I think having the images generated is a great idea, and this can be done by adding them to the gallery and linking them from the gallery. You can look in scikit-learn how it is done there, thought sphinx-gallery generates more plots than our current gallery system, so it needs to be adapted a bit:

		  <div class="item">
		    <a href="{{pathto('auto_examples/neighbors/plot_species_kde') }}">
		      <img src="_images/sphx_glr_plot_species_kde_thumb.png"></a>
		  </div>

(This can be found here: https://github.com/scikit-learn/scikit-learn/blob/master/doc/themes/scikit-learn/layout.html)

@NelleV
Copy link
Copy Markdown
Member

NelleV commented Jan 16, 2017

After discussing with @tacaswell, we're going to merge this as is and backport ASAP to 2.x in preparation for the release.

@NelleV NelleV merged commit e0a3da8 into matplotlib:master Jan 16, 2017
@NelleV NelleV mentioned this pull request Jan 16, 2017
Merged
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 16, 2017

Backported to v2.x as b424478.

@DietBru
Copy link
Copy Markdown
Contributor Author

DietBru commented Jan 16, 2017

@NelleV This probably the best solution. I took a look at the gallery extension and I did not understand how to generate plots without having a rst-page.

@tacaswell tacaswell mentioned this pull request Jan 16, 2017
Closed
@DietBru DietBru deleted the remove_showcase_piechart branch January 17, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DietBru @NelleV @QuLogic @tacaswell
X Tutup