Merged
Conversation
tacaswell
approved these changes
Jan 8, 2017
QuLogic
reviewed
Jan 8, 2017
| # the final request for a polar axes will end up creating one | ||
| # with a spec of 111. | ||
| assert_true(fig.gca(polar=True) is not ax3) | ||
| with warnings.catch_warnings(record=True) as w: |
Member
There was a problem hiding this comment.
Within this context, you also need a warnings.simplefilter('always') or else the warning may not be triggered.
QuLogic
reviewed
Jan 8, 2017
lib/matplotlib/tests/test_figure.py
Outdated
| assert_equal(len(fig.axes), 3) | ||
|
|
||
|
|
||
| @cleanup |
Member
There was a problem hiding this comment.
Contrary to its documentation, plt.figaspect doesn't actually create a new figure, so this shouldn't affect anything.
Current coverage is 62.12% (diff: 100%)@@ master #7765 diff @@
==========================================
Files 174 174
Lines 56028 56028
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
Misses 21223 21223
Partials 0 0
|
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a couple of
@cleanupdecorators, and catch a newish warning. This gets rid of a couple of warnings from the tests.