BF: Convert namespace path to list#7703
Conversation
For some reason, on some systems, the ``__path__`` attribute of a module is a _NamespacePath, not a list, as we expected - see: MacPython/matplotlib-wheels#2
|
Does it have anything to do with how the module is packaged? Say, a zipped egg versus an egg directory? While I am sure this change is fairly innocuous, would it fully address issues arising from the circumstances of these weird situations (in other words, would a path as a namespace path still be useful here?) |
|
This is a private function only used a bit further down to sort out what the full directory is to be able to look for the baseline images in the correct place. (side note cookies are weird, same random version of forward and back browsing lost and then re-found my draft of this text) |
Current coverage is 62.07% (diff: 100%)@@ master #7703 diff @@
==========================================
Files 174 174
Lines 56022 56022
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34774 34775 +1
+ Misses 21248 21247 -1
Partials 0 0
|
TST: Convert namespace path to list
|
Thanks! Backported to v2.x as c51f5ca |
|
Ben - good suggestion about the packaging - I hadn't thought of that - but no, at least installing from the wheel seems to be the same as installing from source. |
For some reason, on some systems, the
__path__attribute of a moduleis a _NamespacePath, not a list, as we expected - see:
MacPython/matplotlib-wheels#2