Change majority of redirected links in docs by dstansby · Pull Request #7693 · matplotlib/matplotlib

dstansby · 2016-12-27T23:01:10Z

Having a play around with the sphinx linkchecker. This PR replaces quite a few links that redirect.

I'll open another PR in a bit for actual broken website changes as opposed to just redirects.

tacaswell · 2016-12-27T23:05:09Z

doc/devel/MEP/MEP12.rst

 .. [3] http://matplotlib.1069221.n5.nabble.com/Matplotlib-gallery-td762.html#a33379091
-.. [4] http://www.loria.fr/~rougier/teaching/matplotlib/
-.. [5] http://www.loria.fr/~rougier/coding/gallery/
+.. [4] http://www.labri.fr/perso/nrougier/teaching/matplotlib/


Is this a typo? Would have guessed it should be http://www.labri.fr/person/rougier/teaching/matplotlib/

It might be a typo on that website, yes!

/perso/ works, but http://www.labri.fr/person/nrougier/teaching/matplotlib/ gives a 404

"perso" = French abbrev. for "personal" so it's probably intended as such.

dstansby · 2016-12-27T23:07:27Z

(FWIW, I've checked that these work by hand, apart from the http --> https changes)

tacaswell · 2016-12-27T23:11:17Z

@QuLogic is going to love this PR 😄 .

QuLogic

Some typos, improvements, etc.

QuLogic · 2016-12-28T07:30:26Z

INSTALL

+`64 bit <https://www.microsoft.com/en-us/download/details.aspx?id=15336>`__
 or
-`32 bit <http://www.microsoft.com/download/en/details.aspx?id=29>`__
+`32 bit <http://www.microsoft.com/en-us/download/details.aspx?id=29>`__


Can add https on this one too.

QuLogic · 2016-12-28T07:30:42Z

INSTALL

-`32 bit <http://www.microsoft.com/download/en/details.aspx?id=29>`__
+`32 bit <http://www.microsoft.com/en-us/download/details.aspx?id=29>`__
 for Python 2.7) or Microsoft Visual C++ 2010 (
 `64 bit <http://www.microsoft.com/en-us/download/details.aspx?id=14632>`__


And this one and the one after it too.

QuLogic · 2016-12-28T07:31:50Z

INSTALL

 `FFmpeg <https://www.ffmpeg.org/>`_, `avconv <https://libav.org/>`_,
 `mencoder <http://www.mplayerhq.hu>`_, or
-`ImageMagick <http://www.imagemagick.org/>`_ are required for the
+`ImageMagick <http://www.imagemagick.org/script/index.php>`_ are required for the


That's an unfortunate redirect; would have been nice if they didn't do that.

QuLogic · 2016-12-28T07:32:11Z

INSTALL


 We provide a `setup.cfg
-<https://github.com/matplotlib/matplotlib/raw/master/setup.cfg.template>`_
+<https://raw.githubusercontent.com/matplotlib/matplotlib/master/setup.cfg.templatef>`_


Extra f added at the end here.

QuLogic · 2016-12-28T07:38:38Z

doc/devel/MEP/MEP13.rst

 Wrap all of the matplotlib getter and setter methods with python
 `properties
-<http://docs.python.org/2/library/functions.html#property>`_, allowing
+<https://docs.python.org/2/library/functions.html#property>`_, allowing


Change 2 to 3.

QuLogic · 2016-12-28T07:47:31Z

doc/glossary/index.rst


  EPS
-      Encapsulated Postscript (`EPS <http://en.wikipedia.org/wiki/Encapsulated_PostScript>`_)
+      Encapsulated Postscript (`EPS <https://en.wikipedia.org/w/index.php?title=Encapsulated_PostScript>`_)


Why all this extra stuff? (This applies to every wiki link in this file.)

They were throwing a weird warning with linkcheker when I just added https, but they seem to be fine in the actual build like that. I'll change them back and just add https.

QuLogic · 2016-12-28T07:50:49Z

doc/users/event_handling.rst

 `animations recipe
-<http://www.scipy.org/Cookbook/Matplotlib/Animations>`_ to make the
-animated drawing faster and smoother.
+<http://scipy-cookbook.readthedocs.io/items/Matplotlib_Animations.html>`_ to


https-able.

QuLogic · 2016-12-28T07:53:54Z

doc/users/usetex.rst

 .. _LaTeX: http://www.tug.org
 .. _dvipng: http://www.nongnu.org/dvipng/
-.. _Ghostscript: http://www.cs.wisc.edu/~ghost/
+.. _Ghostscript: http://pages.cs.wisc.edu/~ghost/


Switch to ghostscript.com like the others?

QuLogic · 2016-12-28T07:54:29Z

lib/matplotlib/cbook.py


      By: Alex Martelli
-      From: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/52308
+      From: http://code.activestate.com/recipes/121294/


https-able.

QuLogic · 2016-12-28T07:54:39Z

lib/matplotlib/cbook.py


    By: Composite of Holger Krekel and Luther Blissett
-    From: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/121294
+    From: http://code.activestate.com/recipes/121294/


https-able.

QuLogic · 2016-12-28T07:57:47Z

It's probably not a good idea to modify the gitwash links and instead regenerate them from the original sources (which should be correct now) like @NelleV did in her PR.

This will also need a rebase after the other PR.

dstansby · 2016-12-28T12:54:05Z

That should be rebased and all the changes requested added, I don't how to regenerate the gitwash links, so feel free to commit to my branch to do that!

tacaswell · 2016-12-29T19:46:18Z

Oh, that did not do what I thought it would do at all.

@dstansby Do you mind cleaning up the mess I made or may I force-push to your branch?

dstansby · 2016-12-29T20:49:34Z

I've undone the merge of master, and rebased again, which I presume was the aim?

codecov-io · 2016-12-29T20:50:11Z

Current coverage is 62.07% (diff: 100%)

Merging #7693 into master will decrease coverage by <.01%

@@             master      #7693   diff @@
==========================================
  Files           174        174          
  Lines         56022      56022          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          34776      34774     -2   
- Misses        21246      21248     +2   
  Partials          0          0

Powered by Codecov. Last update d8f535c...808d996

tacaswell · 2016-12-29T20:53:34Z

Yes, thanks!

tacaswell · 2016-12-29T20:54:38Z

For the record, I used the 'resolve conflict' button that I assume everyone with push rights can see.

NelleV · 2016-12-31T08:19:14Z

Thanks for the pull request @dstansby !

Change majority of redirected links in docs Conflicts: doc/devel/MEP/MEP12.rst - previously not backported changes to text still not backported doc/devel/release_guide.rst - conflicts due to 2.x not having been merged up in a while, a no longer existing link was fixed on master. doc/mpl_toolkits/index.rst - manually fixed some links, master has reorganized this doc/thirdpartypackages/index.rst - does not exist on this branch

tacaswell · 2016-12-31T17:21:18Z

Thanks, backported to v2.x as dba5232

tacaswell added this to the 2.0.1 (next bug fix release) milestone Dec 27, 2016

tacaswell added the Documentation label Dec 27, 2016

tacaswell reviewed Dec 27, 2016

View reviewed changes

dstansby mentioned this pull request Dec 27, 2016

Fix a few broken links in docs #7694

Merged

QuLogic requested changes Dec 28, 2016

View reviewed changes

dstansby force-pushed the doc-links branch from add0e2e to 73854be Compare December 28, 2016 12:50

dstansby force-pushed the doc-links branch from 286daad to 73854be Compare December 29, 2016 20:45

dstansby added 5 commits December 29, 2016 20:47

Add https

6ec29e6

Mass link redirection update

f278217

Catch last few redirect links

567d03a

Fix little link bug

8eb34b2

Requested changes for link redirect fixes

808d996

dstansby force-pushed the doc-links branch from 73854be to 808d996 Compare December 29, 2016 20:48

tacaswell approved these changes Dec 29, 2016

View reviewed changes

NelleV merged commit 196686e into matplotlib:master Dec 31, 2016

QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Dec 31, 2016

dstansby deleted the doc-links branch January 11, 2017 10:06

Uh oh!

Conversation

dstansby commented Dec 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dstansby commented Dec 27, 2016

Uh oh!

tacaswell commented Dec 27, 2016

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Dec 28, 2016

Uh oh!

dstansby commented Dec 28, 2016

Uh oh!

tacaswell commented Dec 29, 2016

Uh oh!

dstansby commented Dec 29, 2016

Uh oh!

codecov-io commented Dec 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 62.07% (diff: 100%)

Uh oh!

tacaswell commented Dec 29, 2016

Uh oh!

tacaswell commented Dec 29, 2016

Uh oh!

NelleV commented Dec 31, 2016

Uh oh!

tacaswell commented Dec 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Dec 29, 2016 •

edited

Loading