Merged
Conversation
AAPL and INTC are no longer required without stock_demo.py, plus there are 3 copies of AAPL data. Convert datetime.date to np.datetime64 to increase portability of the files.
QuLogic
force-pushed
the
sample-data-cleanup
branch
from
46d69a7 to
9ba1fd5
Compare
Kojoley
approved these changes
Dec 30, 2016
Member
Kojoley
left a comment
Kojoley
left a comment
There was a problem hiding this comment.
Disclaimer: I've checked examples only on Py3.5
NelleV
changed the title
Current coverage is 62.16% (diff: 100%)@@ master #7645 diff @@
==========================================
Files 174 174
Lines 56021 56664 +643
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34773 35225 +452
- Misses 21248 21439 +191
Partials 0 0
|
Member
|
Thanks for the clean up! |
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #7559 with the cleanup of the stock sample data that was taken out of there.
AAPL and INTC are no longer required without stock_demo.py, plus there are 3 copies of AAPL data. Convert
datetime.datetonp.datetime64to increase portability of the files.While using
np.datetime64in the NumPy files is more portable across Python versions, Matplotlib still really only supportsdatetimeobjects, so I've had to convert back after loading. This is a bit suboptimal (but not really worse than the existing setup), so now that we depend on NumPy 1.7 which has had a few improvements, it may be time to look into importing thenp.datetime64converter.