Make bars stick to explicitly-specified edges.#7605
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Dec 11, 2016
Merged
Make bars stick to explicitly-specified edges.#7605tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
Previously, they would stick to 0 regardless of any explicit bottom/left position specified by the respective keyword arguments.
efiring
approved these changes
Dec 11, 2016
Member
efiring
left a comment
efiring
left a comment
There was a problem hiding this comment.
Looks good. Thanks for catching and fixing my mistake.
Contributor
|
My guess is that the example dates back to a point where The fix looks good. If you don't plan to update the example I'd suggest opening a separate (nonblocking) issue. |
anntzer
approved these changes
Dec 11, 2016
tacaswell
added a commit
that referenced
this pull request
Dec 11, 2016
MNT: Make bars stick to explicitly-specified edges.
Member
|
Thanks! backported as 4b53790 |
Member
Author
|
Oops, meant to aim that directly at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, they would stick to 0 regardless of any explicit bottom/left position specified by the respective keyword arguments. I assume this was just a minor oversight.
The modified example shows what's wrong here; on
v2.x, it adds margins on all four side once the explicit y-limits are removed. With this change, the bottom margin is removed only. No tests now, but I can try and think one up.