Deprecate unused functions in cbook.#7568
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Dec 19, 2016
Merged
Conversation
anntzer
force-pushed
the
deprecate-unused-cbook
branch
5 times, most recently
from
c88c2a4 to
229cfc3
Compare
tacaswell
reviewed
Dec 5, 2016
lib/matplotlib/cbook.py
Outdated
| return ret | ||
|
|
||
|
|
||
| @deprecated('2.0') |
Member
There was a problem hiding this comment.
This one should be use in the pandas support code...
Member
|
Given that we just did an rc without these, I think they should target 2.1 instead of 2.0. |
Member
|
I actually think that everything currently tagged 2.0.1 that isn't a major bug should target 2.1 |
Contributor
|
@NelleV Agree, except scratch the work 'major'. Any bugfix should target the next bugfix release. |
Contributor
Author
|
Sounds fair. |
anntzer
force-pushed
the
deprecate-unused-cbook
branch
from
229cfc3 to
33c6d92
Compare
anntzer
force-pushed
the
deprecate-unused-cbook
branch
from
33c6d92 to
d85e2b7
Compare
NelleV
changed the title
Member
|
This is long overdue… Thanks for tackling this @anntzer ! |
NelleV
approved these changes
Dec 19, 2016
QuLogic
reviewed
Dec 19, 2016
|
|
||
|
|
||
| @deprecated('2.1') | ||
| def soundex(name, len=4): |
Member
There was a problem hiding this comment.
What in the world did we need this for?
Member
There was a problem hiding this comment.
Dates back to e34a333 (Sept 2004!). Presumably John used this for something....
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think most of the deprecations I propose should be pretty uncontroversial, but feel free to argue otherwise. Let's see whether we can work on reducing the old API...