Clarify to_rgba docstring.#7548
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Dec 4, 2016
Merged
Conversation
NelleV
reviewed
Dec 1, 2016
Member
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
I am fine with merging it as is, but it'd be nicer if it was numpydoc format. Do you mind if I do the change and push to your repository?
Contributor
Author
|
Go ahead. |
Contributor
Author
|
(And you can force-push as much as you want.) |
Current coverage is 61.89% (diff: 100%)@@ master #7548 diff @@
==========================================
Files 173 173
Lines 56140 56172 +32
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34743 34767 +24
- Misses 21397 21405 +8
Partials 0 0
|
Member
|
@NelleV going to merge this as-is (as I want it for the rc), can you follow up with another PR for the formatting? |
Contributor
Author
|
Sure. |
tacaswell
added a commit
that referenced
this pull request
Dec 4, 2016
DOC: Clarify to_rgba docstring.
Member
|
backported to v2.x as 56635c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All's in the title.