Avoid division by zero if headlength=0 for quiver#7525
Merged
efiring merged 3 commits intomatplotlib:masterfrom Nov 28, 2016
rmjarvis:quiver-nohead
Merged
Avoid division by zero if headlength=0 for quiver#7525efiring merged 3 commits intomatplotlib:masterfrom rmjarvis:quiver-nohead
efiring merged 3 commits intomatplotlib:masterfrom
rmjarvis:quiver-nohead
Conversation
NelleV
changed the title
NelleV
approved these changes
Nov 28, 2016
Member
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
LGTM.
i don't know why appveyar is unhappy.
Contributor
Author
It appears to have been unhappy for a while now, so I suspect it is something on master unrelated to this PR. AFAICT, the last commit on master that passed AppVeyor was on Nov 19, when #7481 was merged. I don't think there is anything afterward that passes AppVeyor. |
dopplershift
approved these changes
Nov 28, 2016
Contributor
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
Member
|
Thank you, @rmjarvis. |
efiring
added a commit
that referenced
this pull request
Nov 28, 2016
[MRG+1] Avoid division by zero if headlength=0 for quiver
Member
|
backported to 2.x as ab65830. |
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use quiver a lot with headless arrows to make whisker plots. But the code always outputs a division by zero warning, which I need to suppress. I don't think there is an open issue about this, but it was mentioned on list over four years ago.
Anyway, the fix is simple, so here it is.