Conversation
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Good to see test times down to about the same as nose.
| # https://github.com/pytest-dev/pytest/issues/920 | ||
| # https://github.com/pytest-dev/pytest/issues/1075 | ||
| export PYTHONHASHSEED=$(shuf -i 1-4294967295 -n 1) | ||
| echo PYTHONHASHSEED=$PYTHONHASHSEED |
There was a problem hiding this comment.
Will this affect the determinism tests?
There was a problem hiding this comment.
Aren't the tests that really care about this run in a shell-call with their own seeds set?
There was a problem hiding this comment.
I don't see it set/unset PYTHONHASHSEED, so wouldn't it be inherited?
There was a problem hiding this comment.
Yeah, I think you are right 🐑
There was a problem hiding this comment.
Well, I have find out that xdist collection problem is triggered by test_mathtext.py, but I do not know what exactly, maybe globals() injection magic or something else. I think the best option for us is to rewrite test_mathtext to pytest fixtures and forget about this xdist issue.
There was a problem hiding this comment.
Hmm, that definitely is weird; is there a way to parametrize the fileename passed to the image_comparison decorator?
|
It still looks longer, the nose version it matches is the one for coverage which does not use parallelism. Am I confused? |
|
Oh, I wasn't looking at the parallelism, just that it wasn't exceptionally slow. |
|
We do not run all the tests with nose. |
|
Also the slowdown may be related to the problem described here pytest-dev/pytest-xdist#18 |
|
sorry, I think I was too optimistic about merging this. |
3 participants
No description provided.