FIX: search for tkinter first in builtins#7433
Merged
NelleV merged 1 commit intomatplotlib:masterfrom Nov 9, 2016
Merged
Conversation
Python compiled from Python.org source builds the tkinter module as a
built-in module, not an external module, as is the case for the packaged
builds of Debian etc:
>>> Tkinter.tkinter
<module '_tkinter' (built-in)>
This breaks the MPL algorithm for searching for tkinter symbols, which
loaded the external module .so file to get the symbols.
Try searching in the main program namespace for the tkinter symbols,
before looking for the extermal module .so file.
Thanks to github user ettaka for reporting : see
matplotlib#7428
tacaswell
changed the title
tacaswell
approved these changes
Nov 9, 2016
tacaswell
modified the milestones:
2.0.1 (next bug fix release),
2.1 (next point release),
2.0 (style change major release)
NelleV
added a commit
that referenced
this pull request
Nov 9, 2016
FIX: search for tkinter first in builtins
Member
|
Backported as 033c3f2 Thanks @matthew-brett ! |
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python compiled from Python.org source builds the tkinter module as a
built-in module, not an external module, as is the case for the packaged
builds of Debian etc:
This breaks the MPL algorithm for searching for tkinter symbols, which
loaded the external module .so file to get the symbols.
Try searching in the main program namespace for the tkinter symbols,
before looking for the extermal module .so file.
Thanks to github user ettaka for reporting : see
#7428