X Tutup
Skip to content

Make hatch colour an rcParam.#7415

Merged
efiring merged 1 commit intomatplotlib:v2.xfrom
QuLogic:hatch-colour
Nov 7, 2016
Merged

Make hatch colour an rcParam.#7415
efiring merged 1 commit intomatplotlib:v2.xfrom
QuLogic:hatch-colour

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Nov 5, 2016

This turned out easier than I expected because I just had to follow the same work as #6198. As with hatch.linewidth, there is no API to do this, only the rcParam.

Not sure if I should add an explicit test, some other tests kind of implicitly test this stuff (as seen from the updated images.)

Fixes #7166. Also, partially implements #7059.

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. API: default changes topic: rcparams labels Nov 5, 2016
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Nov 5, 2016
@efiring
Copy link
Copy Markdown
Member

efiring commented Nov 6, 2016

You could add a test based on a simplified version of the example in #7166, so that the legend would be tested.

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Nov 7, 2016

I added a test based on @dopplershift's shortened test in #7166, which I think basically covers the path hit by legends.

Interestingly, it isn't broken in PDF or SVG because they determine the colour in some other way somehow. In fact, there's even a test test_hatching_legend for PDF in test_backend_pdf.py...

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Nov 7, 2016

Hmm, just realized the PDF is broken when using Rectangle without an explicit edge colour, so I must have missed one more place.

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Nov 7, 2016 •
edited
Loading

On closer inspection, that may be a bug in evince, as it appears fine in pdf.js, inkscape and convert/imagemagick.

dopplershift
dopplershift approved these changes Nov 7, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (given that this follows the stuff for hatching line width).

@QuLogic QuLogic changed the title Make hatch colour an rcParam. [MRG+1] Make hatch colour an rcParam. Nov 7, 2016
@QuLogic QuLogic changed the title [MRG+1] Make hatch colour an rcParam. [MRG] Make hatch colour an rcParam. Nov 7, 2016
@efiring efiring merged commit 41f4e37 into matplotlib:v2.x Nov 7, 2016
@efiring efiring changed the title [MRG] Make hatch colour an rcParam. Make hatch colour an rcParam. Nov 7, 2016
@dopplershift dopplershift mentioned this pull request Nov 7, 2016
Closed
@QuLogic QuLogic deleted the hatch-colour branch November 7, 2016 21:17
@andim andim mentioned this pull request Jan 28, 2017
Closed
@tacaswell tacaswell mentioned this pull request Apr 8, 2020
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

API: default changes Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: rcparams

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@QuLogic @efiring @dopplershift
X Tutup