Clarify wspace/hspace in documentation/comments#7399
Clarify wspace/hspace in documentation/comments#7399NelleV merged 2 commits intomatplotlib:masterfrom
Conversation
NelleV
changed the title
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
Thanks for the patch!
This looks good. I have a minor nitpick, we can merge as is.
lib/matplotlib/figure.py
Outdated
| @@ -182,10 +182,12 @@ def __init__(self, left=None, bottom=None, right=None, top=None, | |||
| The top of the subplots of the figure | |||
|
|
|||
| *wspace* : 0.2 | |||
There was a problem hiding this comment.
Do you mind removing the * around the keyword? We don't need them anymore.
There was a problem hiding this comment.
Just for wspace and hspace? The * seem to be ubiquitous. I guess my question is, how far should I go with this?
There was a problem hiding this comment.
Just for this function, else it'll take forever :)
There was a problem hiding this comment.
They're from a time before numpydoc; since numpydoc formats parameters in bold anyway, these have been made redundant. Just no-one's gone through to fix them yet.
There was a problem hiding this comment.
Gotcha. Alright I went through and removed them in a bunch of places in that file. I figured while I was there I wouldn't limit myself to just one class.
|
Thanks! 👍 |
|
No problem. Feels good to contribute. I make heavy use of matplotlib. |
QuLogic
changed the title
|
Thanks @stilley2! Congratulations on your first PR into mpl 🎉 Hopefully we will hear from you again! |
Clarify wspace/hspace in documentation/comments
|
backported to v2.x as 3d3b8d2 In general, I think all of the documentation changes should be backported. |
tacaswell
modified the milestones:
2.0.1 (next bug fix release),
2.1 (next point release)
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
4 participants
Addresses #6939