X Tutup
Skip to content

DOC: Normalize symlink target#7340

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
Kojoley:doc-normalize-symlink-target
Oct 25, 2016
Merged

DOC: Normalize symlink target#7340
tacaswell merged 1 commit intomatplotlib:masterfrom
Kojoley:doc-normalize-symlink-target

Conversation

@Kojoley
Copy link
Copy Markdown
Member

@Kojoley Kojoley commented Oct 24, 2016

Fixes OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect error on docs build.

It happens because symlinks are created with forward slashes, while Windows supports only backward slashes.

@Kojoley
DOC: Normalize symlink target
7e60788 
Fixes `OSError: [WinError 123] The filename, directory name,
or volume label syntax is incorrect` error on docs build.
NelleV
NelleV approved these changes Oct 24, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, soon, we'll move to the more recent and up-to-date way to build the docs… that should solve most of our problems.

LGTM 👍

@NelleV NelleV changed the title DOC: Normalize symlink target [MRG+1] DOC: Normalize symlink target Oct 24, 2016
@tacaswell tacaswell merged commit dc748b8 into matplotlib:master Oct 25, 2016
@WeatherGod
Copy link
Copy Markdown
Member

WeatherGod commented Oct 25, 2016

Huh? Windows supports forward slashes for opening files. I have code that
uses forward slashes that works on both Windows and Linux machines. Is
there some sort of edge case I am not aware of?

On Mon, Oct 24, 2016 at 11:32 AM, Nelle Varoquaux notifications@github.com
wrote:

@NelleV approved this pull request.

Hopefully, soon, we'll move to the more recent and up-to-date way to build
the docs… that should solve most of our problems.

LGTM 👍

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7340 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARy-Mk9caWNPRPR7CyV4hGGCi4Sdewnks5q3M9xgaJpZM4Ke3_s
.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Oct 25, 2016
@QuLogic QuLogic changed the title [MRG+1] DOC: Normalize symlink target DOC: Normalize symlink target Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NelleV NelleV NelleV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Kojoley @WeatherGod @NelleV @tacaswell @QuLogic
X Tutup