X Tutup
Skip to content

Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist#7323

Merged
efiring merged 1 commit intomatplotlib:masterfrom
lzkelley:master
Oct 22, 2016
Merged

Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist#7323
efiring merged 1 commit intomatplotlib:masterfrom
lzkelley:master

Conversation

@lzkelley
Copy link
Copy Markdown
Contributor

@lzkelley lzkelley commented Oct 21, 2016

@lzkelley
Copy link
Copy Markdown
Contributor Author

lzkelley commented Oct 21, 2016

It looks like this is an image comparison error:

2.52s setup lib/matplotlib/tests/test_axes.py::test_specgram_freqs_phase[0-specgram_phase_freqs-png]
2.44s call lib/matplotlib/tests/test_backend_ps.py::test_savefig_to_stringio_with_usetex
2.38s call lib/mpl_toolkits/tests/test_mplot3d.py::test_surface3d[0-surface3d-pdf]
=================================== FAILURES ===================================
____________________ test_mixedsubplots[0-mixedsubplot-svg] ____________________
expected = '/home/travis/build/matplotlib/matplotlib/result_images/test_mplot3d/mixedsubplot-expected.svg'
actual = '/home/travis/build/matplotlib/matplotlib/result_images/test_mplot3d/mixedsubplot.svg'

Is there a way to take a look at these images?
Running the same tests on my machine doesn't produce any errors...

python tests.py mpl_toolkits.tests.test_mplot3d
Python byte-compilation optimization level: 0
/Users/lzkelley/Programs/Public/matplotlib/lib/matplotlib/init.py:1568: UserWarning: matplotlib is not built with the correct FreeType version to run tests. Set local_freetype=True in setup.cfg and rebuild. Expect many image comparison failures below. Expected freetype version 2.5.5. Found freetype version 2.6.1. Freetype build type is not local
"" if ft2font.freetype_build_type == 'local' else "not "

..S..S..S..S..S..S..S...S.....S..S..S....S..S..S....

Ran 52 tests in 14.567s

OK (SKIP=14)

NelleV
NelleV approved these changes Oct 21, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzkelley for the patch!

Sometimes, our tests fail for no good reason. I restarted the tests on travis, and it passes.

@NelleV NelleV changed the title Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist [MRG+1] Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist Oct 21, 2016
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Oct 22, 2016
@efiring efiring merged commit f9b06c8 into matplotlib:master Oct 22, 2016
efiring added a commit that referenced this pull request Oct 22, 2016
@efiring
Merge pull request #7323 from lzkelley/master
b229f99 
[MRG+1] Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist
@efiring
Copy link
Copy Markdown
Member

efiring commented Oct 22, 2016

back ported to v2.x as b229f99.
Thank you, @lzkelley.

@efiring efiring changed the title [MRG+1] Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist Fix #6448: set xmin/ymin even without non-zero bins in 'step' hist Oct 22, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NelleV NelleV NelleV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lzkelley @efiring @NelleV @QuLogic
X Tutup