X Tutup
Skip to content

friendly take over of PR6488#7317

Closed
fariza wants to merge 5 commits intomatplotlib:masterfrom
fariza:aneda-master
Closed

friendly take over of PR6488#7317
fariza wants to merge 5 commits intomatplotlib:masterfrom
fariza:aneda-master

Conversation

@fariza
Copy link
Copy Markdown
Member

@fariza fariza commented Oct 21, 2016

This is a friendly take over of #6488 to finish the review process with last comments about docstring change

@NelleV
Copy link
Copy Markdown
Member

NelleV commented Oct 21, 2016

I hope you don't mind if I add a couple of comments…
Can make the docstrings "sphinx-gallery compatible", as described in the (since) updated MEP12 document? http://matplotlib.org/devdocs/devel/MEP/MEP12.html

@fariza
Copy link
Copy Markdown
Member Author

fariza commented Oct 21, 2016

@NelleV not to be offensive, but the only reason I wanted to take over the PR was because it was stuck due to a simple docstring.
If you want you can take over and I close this one. I really don't mind.
Or just send a PR against this one and I'll accept your changes.

@phobson
Copy link
Copy Markdown
Member

phobson commented Oct 21, 2016

@fariza do you mind if I make a quick edit?

@phobson phobson self-assigned this Oct 21, 2016
@phobson phobson added this to the 2.0.1 (next bug fix release) milestone Oct 21, 2016
@ivanov
Copy link
Copy Markdown
Member

ivanov commented Oct 21, 2016

I added to the dogpile! 🐶 🐶

@NelleV NelleV closed this Oct 21, 2016
@QuLogic QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Oct 22, 2016
@QuLogic QuLogic added the MEP: MEP12 gallery and examples improvements label Oct 22, 2016
@fariza fariza deleted the aneda-master branch October 22, 2016 22:44
@fariza
Copy link
Copy Markdown
Member Author

fariza commented Oct 25, 2016

Please go ahead

On Oct 21, 2016 11:25 AM, "Paul Hobson" notifications@github.com wrote:

@fariza https://github.com/fariza do you mind if I make a quick edit?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7317 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABa86YkGZm_tqWRWP8xhNCEXZMwv6Kx9ks5q2NlkgaJpZM4KcxSr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MEP: MEP12 gallery and examples improvements status: duplicate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup