Merged
Conversation
The requirement is 2.7 or 3.4+.
Kojoley
reviewed
Oct 21, 2016
| if PY3min: | ||
| from urllib.request import urlretrieve | ||
| else: | ||
| from urllib import urlretrieve |
Member
There was a problem hiding this comment.
Why not six.moves.urllib.request.urlretrieve?
Kojoley
reviewed
Oct 21, 2016
| if PY3min: | ||
| config = configparser.ConfigParser() | ||
| else: | ||
| config = configparser.SafeConfigParser() |
Member
There was a problem hiding this comment.
Why not six.moves.configparser.SafeConfigParser?
Member
Author
|
I don't think we can rely on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5373 raised minimum Python to 2.7 or 3.4+. A lot of
try/exceptstuff was removed, but explicit checks ofsys.version_infowere not.