Boxplot zorder kwarg by bcongdon · Pull Request #7178 · matplotlib/matplotlib

bcongdon · 2016-09-26T15:14:30Z

boxplot now accepts the zorder kwarg to set the zorder of the drawn boxplot in the plotting function.

Addresses #7171

tacaswell · 2016-09-26T16:02:34Z

lib/matplotlib/axes/_axes.py

        # empty list of xticklabels
        datalabels = []

-        zorder = mlines.Line2D.zorder


I have a weak preference for this continuing to track mlines.Line2D.zorder by default, but could very easily be talked into change it.

tacaswell · 2016-09-26T16:03:32Z

It is low-risk and an oversight in the API so I think it is reasonable to backport to 2.x. Open to anyone talking me out of this position.

Kojoley · 2016-09-26T16:19:28Z

lib/matplotlib/axes/_axes.py

                labels=None, flierprops=None, medianprops=None,
                meanprops=None, capprops=None, whiskerprops=None,
-                manage_xticks=True, autorange=False):
+                manage_xticks=True, autorange=False, zorder=2):


It is better to have zorder=None here so anyone who want to use default value can pass None explicitly.

Good idea. I debated doing it this way, but streamplot had a default zorder of 2 IIRC, so I went with that convention.

I'll make the change in a bit.

WeatherGod · 2016-09-26T18:25:25Z

If streamplot() still has a hardcoded property kwarg, then that is a bug
and needs to be fixed.

On Mon, Sep 26, 2016 at 2:02 PM, Ben Congdon notifications@github.com
wrote:

@bcongdon commented on this pull request.

In lib/matplotlib/axes/_axes.py
#7178:
@@ -3095,7 +3095,7 @@ def boxplot(self, x, notch=None, sym=None, vert=None, whis=None,
showbox=None, showfliers=None, boxprops=None,
labels=None, flierprops=None, medianprops=None,
meanprops=None, capprops=None, whiskerprops=None,
           manage_xticks=True, autorange=False):
           manage_xticks=True, autorange=False, zorder=2):
Good idea. I debated doing it this way, but streamplot had a default
zorder of 2 IIRC, so I went with that convention.

I'll make the change in a bit.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7178, or mute the thread
https://github.com/notifications/unsubscribe-auth/AARy-NFh9wQq9hQ7EJbEkZs_nq_67wR8ks5quAjAgaJpZM4KGpZz
.

tacaswell · 2016-09-26T21:37:38Z

@WeatherGod bug seems a bit strong, just one more piece of technical debt 😉

bcongdon · 2016-09-26T23:55:38Z

It looks like streamplot does still have that hard-coded value. Should I open a separate PR for that issue, or include it in this one?

efiring · 2016-09-27T00:04:13Z

On 2016/09/26 1:55 PM, Ben Congdon wrote:

It looks like |streamplot| does still have that hard-coded value. Should
I open a separate PR for that issue, or include it in this one?

A separate PR would be good.

tacaswell · 2016-09-27T01:04:31Z

lib/matplotlib/axes/_axes.py

            boxprops=None, whiskerprops=None, flierprops=None,
            medianprops=None, capprops=None, meanprops=None,
-            meanline=False, manage_xticks=True):
+            meanline=False, manage_xticks=True, zorder=2):


Can you change this to None too?

tacaswell · 2016-09-27T01:05:12Z

lib/matplotlib/axes/_axes.py

                                stats['cihi'] = ci[1]

+        # Use default zorder if none specified
+        if zorder is None:


This should be moved to bxp and just let the None pass through this function.

bcongdon · 2016-09-28T14:13:09Z

I made the requested change. Any insight as to why the tests are failing?

tacaswell · 2016-09-28T23:00:11Z

the travis test was flaky, that test is known-fail on windows that we have not dealt with yet.

NelleV · 2016-09-29T03:29:12Z

Thanks @bcongdon !

Boxplot zorder kwarg

QuLogic · 2016-10-16T20:11:49Z

Backported to v2.x via e801685.

bcongdon added 3 commits September 26, 2016 09:29

Adding zorder to boxplot

6ab20f6

Added box plot zorder test

72b5d3e

Added what's new entry for box plot zorder

8146094

mdboom added the status: needs review label Sep 26, 2016

tacaswell reviewed Sep 26, 2016

View reviewed changes

tacaswell added this to the 2.0.1 (next bug fix release) milestone Sep 26, 2016

Kojoley reviewed Sep 26, 2016

View reviewed changes

bcongdon force-pushed the boxplot-zorder branch 2 times, most recently from 9fe3a36 to 0723cd5 Compare September 26, 2016 20:39

tacaswell reviewed Sep 27, 2016

View reviewed changes

tacaswell requested changes Sep 27, 2016

View reviewed changes

Set None be the default for box plot zorder

8c90b1c

bcongdon force-pushed the boxplot-zorder branch from 0723cd5 to 8c90b1c Compare September 27, 2016 11:29

bcongdon mentioned this pull request Sep 27, 2016

Remove hard-coded streamplot zorder kwarg #7188

Merged

tacaswell approved these changes Sep 28, 2016

View reviewed changes

tacaswell changed the title ~~Boxplot zorder kwarg~~ [MRG+1] Boxplot zorder kwarg Sep 28, 2016

NelleV merged commit f8d05a4 into matplotlib:master Sep 29, 2016

mdboom removed the status: needs review label Sep 29, 2016

QuLogic changed the title ~~[MRG+1] Boxplot zorder kwarg~~ Boxplot zorder kwarg Oct 15, 2016

QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016

Merge pull request matplotlib#7178 from bcongdon/boxplot-zorder

e801685

Boxplot zorder kwarg

QuLogic removed this from the 2.0.1 (next bug fix release) milestone Dec 7, 2016

QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Dec 7, 2016

afvincent mentioned this pull request Feb 19, 2017

axes.boxplot does not have zorder kwarg #7171

Closed

Uh oh!

Conversation

bcongdon commented Sep 26, 2016

Uh oh!

tacaswell Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

tacaswell commented Sep 26, 2016

Uh oh!

Kojoley Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

bcongdon Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

WeatherGod commented Sep 26, 2016

@bcongdon commented on this pull request.

Uh oh!

tacaswell commented Sep 26, 2016

Uh oh!

bcongdon commented Sep 26, 2016

Uh oh!

efiring commented Sep 27, 2016

Uh oh!

tacaswell Sep 27, 2016

Choose a reason for hiding this comment

Uh oh!

tacaswell Sep 27, 2016

Choose a reason for hiding this comment

Uh oh!

bcongdon commented Sep 28, 2016

Uh oh!

tacaswell commented Sep 28, 2016

Uh oh!

NelleV commented Sep 29, 2016

Uh oh!

QuLogic commented Oct 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants