Fix branch name in "Deleting a branch on GitHub_" section#7131
Fix branch name in "Deleting a branch on GitHub_" section#7131NelleV merged 3 commits intomatplotlib:masterfrom
Conversation
|
|
||
| (Note the colon ``:`` before ``test-branch``. See also: | ||
| Note the colon ``:`` before ``my-unwanted-branch``. See also: | ||
| http://github.com/guides/remove-a-remote-branch |
There was a problem hiding this comment.
Can you make this https while you're here?
There was a problem hiding this comment.
https://github.com/guides/remove-a-remote-branch does not seem to be valid and redirects toward https://help.github.com/categories/managing-remotes/. From there, I have chosen the (https) link that sounded related to "removing a remote branch".
There was a problem hiding this comment.
No, that link is for deleting a remote itself, not the a remote branch. I think the correct link is https://help.github.com/articles/pushing-to-a-remote/#deleting-a-remote-branch-or-tag
|
Huh, the Travis failure report looks weird compared to the ones I am used to (and it is way longer). Is it something normal? |
|
Given that you only changed rst files, it is almost certainly just the tests being flaky. Restarted the failing test. |
|
The report looks different because that run uses pytest instead of nose. |
|
Thanks! |
|
@NelleV I think that @QuLogic is right : I was tricked by the URL name and the correct link should be https://help.github.com/articles/pushing-to-a-remote/#deleting-a-remote-branch-or-tag, where the presented solution is indeed similar to @tacaswell 's code and remark. Should I correct this in a new PR or is there a way to do otherwise (like reverting the fresh merge)? |
|
just do another PR. |
|
Backported to v1.5.3-doc as f99de8a. |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
5 participants
@tacaswell : I could not find any "test_branch" in the example code in the "Deleting a branch on GitHub_" section, so I guess it was simply an old name forgotten after a change.