X Tutup
Skip to content

FIX: testings.nose was not installed#7055

Merged
jenshnielsen merged 1 commit intomatplotlib:masterfrom
NelleV:fix_test_nose
Sep 8, 2016
Merged

FIX: testings.nose was not installed#7055
jenshnielsen merged 1 commit intomatplotlib:masterfrom
NelleV:fix_test_nose

Conversation

@NelleV
Copy link
Copy Markdown
Member

@NelleV NelleV commented Sep 7, 2016

I am not sure how the tests work on any platform right now… testing.nose was not installed, so the tests could not run.

Note: the tests cannot run on most platforms
@Kojoley
Copy link
Copy Markdown
Member

Kojoley commented Sep 7, 2016

Thanks for fixing my mistake!

@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Sep 7, 2016

My humble opinion is that this shows an underlying problem on the way travis runs the tests (and in general how brittle matplotlib's tests are). At some point, it might be worth doing major reorganization of the repository to have it follow a more traditional organization.
I just hope this hasn't been around for too long, as this show that people don't run the tests on their laptop :)

@tacaswell
Copy link
Copy Markdown
Member

The tests will run correctly if you install via python setup.py develop / pip install -e . (which is how I do it).

@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Sep 8, 2016

appveyor seems unhappy for a font problem. That seems quite unrelated to this PR. Is there a way to relaunch it?

@afvincent
Copy link
Copy Markdown
Contributor

@NelleV Closing the PR and reopening it usually does the trick.

@jenshnielsen
Copy link
Copy Markdown
Member

The appveyor issue is unrelated and hopefully fixed by #7063

@jenshnielsen jenshnielsen merged commit 67a5170 into matplotlib:master Sep 8, 2016
@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Sep 8, 2016

@jenshnielsen I saw the PR and I'll wait until it is merged to rebase.

@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Sep 8, 2016

I guess I won't rebase! Thanks!

@NelleV NelleV deleted the fix_test_nose branch September 8, 2016 14:10
@jenshnielsen
Copy link
Copy Markdown
Member

I didn't want to hold back your work since this is a serious bug and the failure clearly unrelated

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup