DOC specgram() documentation now in numpy style#7038
DOC specgram() documentation now in numpy style#7038Exhor wants to merge 2 commits intomatplotlib:masterfrom
Conversation
| Compute and plot a spectrogram of data in *x*. Data are split into | ||
| *NFFT* length segments and the spectrum of each section is | ||
| computed. The windowing function *window* is applied to each | ||
| Compute and plot a spectrogram of data in x. Data are split into |
There was a problem hiding this comment.
Why remove the special formatting on the argument names? It makes them stand out more.
There was a problem hiding this comment.
It also makes it harder to read in plain text. I prefer it this way.
|
It appears you have not set the config for your git client. All your commits are attributed to "Your Name you@example.com", which is probably not what you want. |
lib/matplotlib/mlab.py
Outdated
| The number of points of overlap between blocks. The default | ||
| value is 128. | ||
| mode : str, optional | ||
| What sort of spectrum to use, default is 'psd'. |
There was a problem hiding this comment.
There is trailing space at the end of this line. Can you please remove it?
|
Great job on this PR! the documentation looks much better now. |
|
It looks good and all the tests pass! Great job! |
|
Does this render right with the replacement params? |
|
I'll check once I arrive home and add a screenshot to the PR. On Sep 11, 2016 11:31 AM, "Thomas A Caswell" notifications@github.com
|
|
Here is how it renders.
|
|
The name on the first commit needs to be fixed. If you are not comfortable with rebasing before hand, we need to remember to do so before merging. |
|
Quite new to git. Rebase makes me scared. |
|
@Exhor I'll take care of it :) |
|
Can you remind me your email address? |
|
On 15 Sep 2016 5:12 pm, "Nelle Varoquaux" notifications@github.com wrote:
|
|
Thanks! I've rebased with this email address. |
5 participants
Changed documentation of lib/mlab.py for function specgram(), now in Numpy style.
@NelleV
Thanks.