DOC Updated plot_date to NumPy/SciPy style by klaragerlei · Pull Request #7033 · matplotlib/matplotlib

klaragerlei · 2016-09-05T15:24:05Z

Hello,

We updated the documentation of plot_date to NumPy/SciPy style.

Thanks,
Michael, Klara

QuLogic · 2016-09-05T21:49:22Z

lib/matplotlib/axes/_axes.py

                  **kwargs):
        """
-        Plot with data with dates.
+	A plot with data that contains dates.


These tabs need to be replaced with the correct number of spaces.

QuLogic · 2016-09-06T04:53:48Z

It appears you have not set the config for your git client. All your commits are attributed to "Your Name you@example.com", which is probably not what you want.

NelleV · 2016-09-06T08:06:10Z

lib/matplotlib/axes/_axes.py

+	See Also
+    	--------
+    	mod : matplotlib.dates for helper functions
+        func : matplotlib.dates.date2num


There is a strange indentation here.
In addition, we need to revert back to the old syntax: :func:~matplotlib.dates.date2num for proper formatting.

NelleV · 2016-09-06T08:06:28Z

Hi Michael & Klara,

The code currently has a mixture of tabs and space, due to gedit not being configured correctly. I can drop by at some point today to help you fix that.
line 1459 also appears to be too long.
Once this is fixed, I think looks great!

Thanks,
Nelle

QuLogic · 2016-09-06T21:16:59Z

lib/matplotlib/axes/_axes.py

-        Similar to the :func:`~matplotlib.pyplot.plot` command, except
+        A plot with data that contains dates.
+
+        Similar to the :func:~matplotlib.pyplot.plot command, except


The backticks should not have been removed here.

QuLogic · 2016-09-06T21:21:11Z

Please remember to correct the name and committer on the first commit.

NelleV · 2016-09-07T10:21:09Z

@QuLogic FYI, we did it, but it requires rebasing and some quite complex operations. I don't think that should be a requirement for contributing to matplotlib (in addition, some people may want to stay anonymous).

NelleV · 2016-09-07T10:28:26Z

@klaragerlei There is still a couple of problems: I can help you with those during a break or the tutors consulting hours tonight if you'd like.

klaragerlei · 2016-09-07T12:56:24Z

That would be great @NelleV , thank you!
On 7 Sep 2016 11:29, "Nelle Varoquaux" notifications@github.com wrote:

@klaragerlei https://github.com/klaragerlei There is still a couple of
problems: I can help you with those during a break or the tutors consulting
hours tonight if you'd like.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7033 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP4NnzXEa0B_GoXdRBinF5QGj8JmTizqks5qnpHWgaJpZM4J1KY4
.

QuLogic · 2016-09-09T01:20:00Z

lib/matplotlib/axes/_axes.py

-                     ydate=False, **kwargs)
-
+        A plot with data that contains dates.
+


There is still some whitespace on this line.

QuLogic · 2016-09-09T01:20:59Z

It appears that you were able to take care of the rebasing? Just a small note that your name appears differently in some of the commits.

CI isn't happy right now, but it is raising a cryptic error. We will have to try a local build to figure out what is wrong.

QuLogic · 2016-09-09T01:22:13Z

lib/matplotlib/axes/_axes.py

+        Other Parameters
+        ----------------
+        kwargs : class : matplotlib.lines.Line2D
+        properties : %(Line2D)s


Line2D gets expanded into several parameter listings; it should be on its own line. (And likely needs to be updated to match this formatting.)

NelleV · 2016-09-14T03:09:17Z

Thanks a lot! This is looks great:

QuLogic · 2016-09-14T03:30:59Z

Are you okay with some commits using your GitHub username and not your real name like the rest of them? Also, all but the second-last commit use the email of @clairesophie but the name is @klaragerlei. Please double-check that you will be attributed correctly.

NelleV · 2016-09-14T03:32:31Z

This PR has been done as pair coding, so it is going to be hard to attribute it properly.

klaragerlei · 2016-09-14T15:22:16Z

@QuLogic I think I managed to fix the double account problem, and it's all correct now, thank you for noticing.

NelleV · 2016-09-14T15:28:12Z

@klaragerlei Thanks!

DOC Updated plot_date to NumPy/SciPy style

tacaswell · 2016-09-14T15:42:50Z

backported to v2.x as 2ddc50e

QuLogic · 2016-09-14T21:51:13Z

There were still two emails with the same name used for different commits; are they the same person?

klaragerlei · 2016-09-15T08:38:23Z

Yes, both of them are mine, sorry, one of them is a university email
address, and the other one is personal. I realized that the university
email address might not be permanent enough, so I switched to using the
other one, but I used that email address ages ago on github for
contributing to a funny robot game, but I completely forgot (this is how
the other account appeared in my commit when I used the personal email in
the configurations), but now I deleted the old account and added both
emails to the same account, so I hope it's all fine now.

On 14 September 2016 at 22:51, Elliott Sales de Andrade <
notifications@github.com> wrote:

There were still two emails with the same name used for different commits;
are they the same person?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7033 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP4Nn64XfFRElOwWjqnsx6NIaYRVCoAKks5qqGxcgaJpZM4J1KY4
.

mdboom added the status: needs review label Sep 5, 2016

klaragerlei changed the title ~~Updated plot_date documentation to NumPy/SciPy style~~ DOC Updated plot_date to NumPy/SciPy style Sep 5, 2016

QuLogic reviewed Sep 5, 2016
View reviewed changes

QuLogic added the Documentation label Sep 6, 2016

NelleV reviewed Sep 6, 2016
View reviewed changes

QuLogic reviewed Sep 6, 2016
View reviewed changes

klaragerlei force-pushed the matplotlib_plot_date_docs branch from 92d6a88 to d1e7037 Compare September 7, 2016 10:05

QuLogic reviewed Sep 9, 2016
View reviewed changes

klaragerlei and others added 6 commits September 10, 2016 03:18

DOC Updated plot_date documentation to NumPy/SciPy style

0704479

DOC changed tabs to spaces, formatted functions to old format

92f8302

FIX Fixed missing backticks, removed extra spaces around colon.

692bb4a

FIX Fixed more missing backticks

16381cf

DOC deleted whitespace

8968ad3

FIX See also in plot_date is rendered properly

e0b8239

klaragerlei force-pushed the matplotlib_plot_date_docs branch from 8c3cea8 to e0b8239 Compare September 10, 2016 13:31

NelleV changed the title ~~DOC Updated plot_date to NumPy/SciPy style~~ [MRG+1] DOC Updated plot_date to NumPy/SciPy style Sep 14, 2016

NelleV merged commit 0309e38 into matplotlib:master Sep 14, 2016

mdboom removed the status: needs review label Sep 14, 2016

tacaswell pushed a commit that referenced this pull request Sep 14, 2016

Merge pull request #7033 from klaragerlei/matplotlib_plot_date_docs

2ddc50e

DOC Updated plot_date to NumPy/SciPy style

QuLogic added this to the 2.0 (style change major release) milestone Sep 17, 2016

QuLogic changed the title ~~[MRG+1] DOC Updated plot_date to NumPy/SciPy style~~ DOC Updated plot_date to NumPy/SciPy style Oct 16, 2016

Uh oh!

Conversation

klaragerlei commented Sep 5, 2016

Uh oh!

QuLogic Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Sep 6, 2016

Uh oh!

NelleV Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

NelleV commented Sep 6, 2016

Uh oh!

QuLogic Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Sep 6, 2016

Uh oh!

NelleV commented Sep 7, 2016

Uh oh!

NelleV commented Sep 7, 2016

Uh oh!

klaragerlei commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuLogic Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Sep 9, 2016

Uh oh!

QuLogic Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

NelleV commented Sep 14, 2016

Uh oh!

QuLogic commented Sep 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NelleV commented Sep 14, 2016

Uh oh!

klaragerlei commented Sep 14, 2016

Uh oh!

NelleV commented Sep 14, 2016

Uh oh!

tacaswell commented Sep 14, 2016

Uh oh!

QuLogic commented Sep 14, 2016

Uh oh!

klaragerlei commented Sep 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

klaragerlei commented Sep 7, 2016 •

edited

Loading

QuLogic commented Sep 14, 2016 •

edited

Loading