Catch invalid interactive switch to log scale.#6983
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Aug 27, 2016
Merged
Catch invalid interactive switch to log scale.#6983tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
`plt.plot([1, 2], [-1, -2])` and press `l` (switch y to log-scale). Before, this would crash the Qt5 backend and cause an invalid internal state in others, due to the complete lack of positive values. Now a warning is printed and the command is cancelled.
Member
|
Makes sense to me. How does the warning look. Should we change it to something more user friendly? |
Contributor
Author
I think it's clear enough? |
Member
|
Yes 👍 |
Contributor
|
Looks good. I wasn't aware of the warnings module. Good to know! |
tacaswell
added a commit
that referenced
this pull request
Aug 27, 2016
…id-log FIX: Catch invalid interactive switch to log scale. Conflicts: lib/matplotlib/backend_bases.py did not backport draw -> draw_idle change
Member
|
backported to v2.x as ac01d85 |
QuLogic
modified the milestones:
2.0 (style change major release),
2.1 (next point release)
This was referenced Sep 12, 2016
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plt.plot([1, 2], [-1, -2])and pressl(switch y to log-scale).Before, this would crash the Qt5 backend and cause an invalid internal
state in others, due to the complete lack of positive values. Now a
warning is printed and the command is cancelled.
See #6852.