Restore cbook.report_memory, which was deleted in d063dee.#6944
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Aug 20, 2016
Merged
Restore cbook.report_memory, which was deleted in d063dee.#6944tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
There was no deprecation process, and having something like this available as an import is very valuable to users suspecting a memory leak, or simply needing to track memory usage.
Member
Author
|
As an example of why we need this, or a good replacement, see #6940. |
Member
|
It looks like the loop from https://github.com/matplotlib/matplotlib/pull/5360/files#diff-84d254616071e10903ac389d05d109deR36 should be exposed as a cbook function as well? |
tacaswell
modified the milestones:
2.1 (next point release),
2.0 (style change major release)
Member
|
re-milestoned as 2.1 because this has only been removed on master (https://github.com/matplotlib/matplotlib/blob/v2.x/lib/matplotlib/cbook.py#L1439) |
Member
Author
|
@tacaswell, yes, it would be nice to have the whole |
Member
|
Merging this as-is as the alternative is much more work than I anticipated due to py3 only imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no deprecation process, and having something like this
available as an import is very valuable to users suspecting a
memory leak, or simply needing to track memory usage.