enable previously leftout test_usetex#6918
Conversation
|
Have not had the time to investigate why the png test fails. It passes with that image for me locally. |
jenshnielsen
force-pushed
the
addtestusetextodefaulttests
branch
from
9030879 to
50c0b74
Compare
|
Reproduced the failure locally on a Ubuntu 12.04 vm. The text looks correct but is slightly different. I don't think this is a font issue so it is probably due to different tex versions. |
|
This still need a skip if not latex decorator |
Cannot use the decorator for similar reasons as matplotlib#6263
|
I think this is ready to land now |
|
@jenshnielsen please try to rearrange extension order. If it will pass with |
|
@Kojoley Good point, I will give it a try |
lib/matplotlib/tests/test_usetex.py
Outdated
| check_output(cmd) | ||
| except: | ||
| from nose import SkipTest | ||
| raise SkipTest('missing command: %s' % cmd[0]) |
There was a problem hiding this comment.
Why not to use skip_if_command_unavailable decorator?
There was a problem hiding this comment.
Please read the commit message
There was a problem hiding this comment.
Please read the commit message
The actual problem commit is gone there and only comment left. :(
At least you can simplify this with matplotlib.checkdep_tex() call.
There was a problem hiding this comment.
I have updated this to use checkdep_usetex which is what we want
|
I think this is ready to merge, the change in coverage seems to be a fluke. The tolerance does not seem to depend on the order it is passing and failing on different backends because of tex version differences. I can reproduce the image that matches travis on a ubuntu 12.04 vm (same os and texlive version as travis) but get different results with a modern texlive install. |
The tests where fixed in matplotlib#6918 but not enabled for pytest
3 participants
Follow up to #6917 with the tests only on master