Fix Path deepcopy signature#6877
Conversation
|
👍 For anyone else wanting more information on I don't think any of the tests failures were related--I restarted the failing Travis jobs to confirm. Can someone restart the AppVeyor job? |
|
https://docs.python.org/3.5/library/copy.html?highlight=__deepcopy__ <- fixed the link for you 👿 Do we need to do anything with memo? |
|
However, hold on this until I can fix another issue with the copy. I am not in position to do so at the moment. |
|
@tacaswell What link problem? 😁 I blame Google/Python defaulting to 2.x on the docs when I search. |
**Problem** Path.__deepcopy__ does not accept a second(`memo`) parameter, so the common usage of the `deepcopy` function fails. **Solution** Add second parameter. While at it, also take care of the case of copying the `Path` without codes.
|
Okay. I fixed the other issue of not being able to deecopy if the path had no codes. |
QuLogic
modified the milestones:
2.0 (style change major release),
2.0.1 (next bug fix release)
5 participants
Problem
Path.__deepcopy__does not accept a second(memo) parameter,so the common usage of the
deepcopyfunction fails.Solution
Add second parameter.