X Tutup
Skip to content

better freetype version checking#6803

Merged
WeatherGod merged 2 commits intomatplotlib:masterfrom
prhbrt:freetype-version-check
Jul 20, 2016
Merged

better freetype version checking#6803
WeatherGod merged 2 commits intomatplotlib:masterfrom
prhbrt:freetype-version-check

Conversation

@prhbrt
Copy link
Copy Markdown

@prhbrt prhbrt commented Jul 20, 2016

No description provided.

@prhbrt
Copy link
Copy Markdown
Author

prhbrt commented Jul 20, 2016

continuation of #6403, to fix the commit message log - as an alternative git rebase.

"Expect many image comparison failures below.")
"Expect many image comparison failures below. "
"Expected freetype version {0}. "
"Found freetype version {1}."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after period.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also not the case in the original, so I don't see the problem.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was not the case in the original? The original had spaces between sentences. This one is missing a space between two sentences.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, don't worry. We won't ask you to rebase/squash for this. It was only to clean out a messy revision history. Fixing one little thing doesn't need a rebase/squash in my opinion.

@WeatherGod
Copy link
Copy Markdown
Member

All the appveyor jobs are still queued. I am going to go ahead and just merge this.

@WeatherGod WeatherGod merged commit 96003f9 into matplotlib:master Jul 20, 2016
WeatherGod added a commit that referenced this pull request Jul 20, 2016
@WeatherGod
Copy link
Copy Markdown
Member

backported to v2.x as ca5324c

@WeatherGod
Copy link
Copy Markdown
Member

@prinsherbert, thank you for bearing with us through the review process.

@prhbrt
Copy link
Copy Markdown
Author

prhbrt commented Jul 20, 2016

Thank you for merging!

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup