Allow creating annotation arrows w/ default props.#6799
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Jul 26, 2016
Merged
Allow creating annotation arrows w/ default props.#6799tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
Member
|
👍 to merging this change. Although it is not a documented API change, I think this should get an api_changes entry noting that the code has been brought inline with the documentation. |
anntzer
force-pushed
the
annotation-default-arrow
branch
2 times, most recently
from
c839c26 to
2948af6
Compare
`annotate(..., arrowprops={})` now uses an arrow with the default arrow
properties, rather than no arrow. Note that this matches the docstring
of `annotate`, which indicates that "arrowprops, if not None, is a
dictionary of line properties (see matplotlib.lines.Line2D) for the
arrow that connects annotation to the point."
Comes down to checking for `None` instead of falsiness of `arrowprops`.
anntzer
force-pushed
the
annotation-default-arrow
branch
from
2948af6 to
5dd8bcb
Compare
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
annotate(..., arrowprops={})now uses an arrow with the default arrowproperties, rather than no arrow. Note that this matches the docstring
of
annotate, which indicates that "arrowprops, if not None, is adictionary of line properties (see matplotlib.lines.Line2D) for the
arrow that connects annotation to the point."
Comes down to checking for
Noneinstead of falsiness ofarrowprops.