TST: reset rcparams in animation smoke test#6767
Merged
efiring merged 1 commit intomatplotlib:v2.xfrom Sep 5, 2016
Merged
Conversation
Member
|
An explanatory comment would not be unwelcome. |
tacaswell
force-pushed
the
tst_win_reg_fix
branch
from
ab3db80 to
d02a65f
Compare
Member
Author
|
@QuLogic fixed. |
| def check_save_animation(writer, extension='mp4'): | ||
| try: | ||
| # for ImageMagick the rcparams must be patched to account for | ||
| # 'concvert' being a built in MS tool, not the imagemagick |
Member
|
I'd also mention that it's because |
Member
Author
|
This maybe revealing a much larger problem that this fix is sweeping under the rug. Some one needs to look into if |
tacaswell
force-pushed
the
tst_win_reg_fix
branch
from
d02a65f to
37785c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6523
attn @cgohlke