X Tutup
Skip to content

Fixed path caching bug in Path.unit_regular_star#6697

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
Kojoley:fix-path-cache-in-unit_regular_star
Jul 6, 2016
Merged

Fixed path caching bug in Path.unit_regular_star#6697
tacaswell merged 1 commit intomatplotlib:masterfrom
Kojoley:fix-path-cache-in-unit_regular_star

Conversation

@Kojoley
Copy link
Copy Markdown
Member

@Kojoley Kojoley commented Jul 6, 2016

No description provided.

@Kojoley
Copy link
Copy Markdown
Member Author

Kojoley commented Jul 6, 2016

Any reason for implementing cache with WeakValueDictionary? I see no problem just to use dict here.
I think this place is where functools.lru_cache decorator can be used (but with some python 2 fallback)

@mdboom
Copy link
Copy Markdown
Member

mdboom commented Jul 6, 2016

👍 from me

@tacaswell tacaswell merged commit 3590ce2 into matplotlib:master Jul 6, 2016
@tacaswell
Copy link
Copy Markdown
Member

Thanks!

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 6, 2016
@Kojoley Kojoley deleted the fix-path-cache-in-unit_regular_star branch July 12, 2016 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup