X Tutup
Skip to content

Merge pull request #5389 from mdboom/webagg-speed#6667

Merged
tacaswell merged 1 commit intomatplotlib:v2.xfrom
tacaswell:backport_png_updates
Jun 30, 2016
Merged

Merge pull request #5389 from mdboom/webagg-speed#6667
tacaswell merged 1 commit intomatplotlib:v2.xfrom
tacaswell:backport_png_updates

Conversation

@tacaswell
Copy link
Copy Markdown
Member

@tacaswell tacaswell commented Jun 30, 2016

Faster image generation in WebAgg/NbAgg backends

Conflicts:
src/_png.cpp
Due to having previously backported #5910 ( 3675841 ) as
( 99ad89d )

This backport is to provide a consistent API to _png for all 2.x versions to make things easier for @SylvainCorlay and company to pull nbagg out of core.

Closes https://github.com/SylvainCorlay/jupyter-matplotlib/issues/2

Faster image generation in WebAgg/NbAgg backends

Conflicts:
	src/_png.cpp
	  Due to having previously backported matplotlib#5910 ( 3675841 ) as
	  ( 99ad89d )
@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jun 30, 2016
@SylvainCorlay
Copy link
Copy Markdown
Member

Awesome thanks!

@tacaswell
Copy link
Copy Markdown
Member Author

Self-merging as this is a backport. @mdboom agreed on in private channels.

@tacaswell tacaswell merged commit c4fa469 into matplotlib:v2.x Jun 30, 2016
@tacaswell tacaswell deleted the backport_png_updates branch June 30, 2016 12:44
@SylvainCorlay
Copy link
Copy Markdown
Member

@tacaswell do you guys plan on having a second beta?

@tacaswell
Copy link
Copy Markdown
Member Author

Yes, probably this weekend (right before scipy).

@SylvainCorlay
Copy link
Copy Markdown
Member

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup