Register figureoptions edits in views history.#6598
Register figureoptions edits in views history.#6598tacaswell merged 2 commits intomatplotlib:masterfrom
Conversation
| @partial(canvas.mpl_connect, 'draw_event') | ||
| def define_home(event): | ||
| self.push_current() | ||
| canvas.mpl_disconnect(define_home) |
There was a problem hiding this comment.
We need to update the docs on mpl_disconnect that this works with a function instead of a cid.
Independent of that, I do not see where this is used.
There was a problem hiding this comment.
Ah, I now understand this and I like it 😄
I have not seen this pattern before, can you leave a short comment as to what this is doing?
tacaswell
modified the milestones:
2.0.1 (next bug fix release),
2.1 (next point release)
|
Modulo a comment for the sake of other maintainers 👍 |
anntzer
force-pushed
the
history-for-figureoptions
branch
3 times, most recently
from
488ed9e to
ebb2c01
Compare
|
I think this picked up a merge conflict from #6599 |
anntzer
force-pushed
the
history-for-figureoptions
branch
from
ebb2c01 to
70dcaa6
Compare
|
Fixed. |
|
If you use |
|
I think this will also insert a state when only changing colors etc. I think the |
|
Done. |
anntzer
force-pushed
the
history-for-figureoptions
branch
from
beb642c to
486f0b1
Compare
|
Kindly bumping. |
|
This has conflicts from (I suspect) the alpha related PR. |
Changing axes limits in views history is now taken into account by the views history navigation. The home position is now defined the first time the figure canvas is drawn (rather than the first time an edit button is selected), via a one-shot callback.
Thanks to @tacaswell for fixing the case where the multiple edits are applied consecutively.
anntzer
force-pushed
the
history-for-figureoptions
branch
from
486f0b1 to
d601ad1
Compare
|
done |
4 participants
Changing axes limits in views history is now taken into account by the
views history navigation. The home position is now defined the first
time the figure canvas is drawn (rather than the first time an edit
button is selected), via a one-shot callback.