BLD: try to limit what coveralls looks at#6524
Closed
phobson wants to merge 1 commit intomatplotlib:masterfrom
Closed
BLD: try to limit what coveralls looks at#6524phobson wants to merge 1 commit intomatplotlib:masterfrom
phobson wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Member
|
Neither of the sample Python projects from coveralls use this other file; are you sure it's necessary? |
Member
Author
|
Perhaps it's not. I picked up the practice from the statsmodels repo, but that dates back to 2013. xarray uses just a plain |
Member
|
I don't think the coverage has ever looked at the examples. The coverage in #6522 does not fail due to the change in your example but because it thinks a line has dropped coverage in colors.py I think it gets confused about which branch to compare against so we can just ignore it. |
Member
Author
|
I don't think this PR accomplished what I thought it did and even it if did, it wouldn't be necessary. closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.