Merged
Conversation
anything but the main Python app
Member
|
@mdehoon Can you review this? |
Contributor
|
Looks OK to me. A better solution (long term) may be to use [NSApp run]; then we don't need a tap. |
Member
|
Just for the record, can someone explain what a "quartz tap" is? On Tue, Jul 19, 2016 at 12:03 AM, mdehoon notifications@github.com wrote:
|
Member
|
back-ported to 2.x as fd7eeeb |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for issue #6429 to prevent macosx backend from trying to add a quartz tap on anything but the main Python app. A better approach might be to add the tap without having to wait on the launch notification avoiding having to parse through any child subprocesses