Update demo_floating_axes.py with comments#6369
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom May 6, 2016
dstansby:floating-axis-comments
Merged
Update demo_floating_axes.py with comments#6369tacaswell merged 2 commits intomatplotlib:masterfrom dstansby:floating-axis-comments
tacaswell merged 2 commits intomatplotlib:masterfrom
dstansby:floating-axis-comments
Conversation
|
|
||
| grid_locator2 = MaxNLocator(3) | ||
|
|
||
| # Set theta limits in degrees |
Member
There was a problem hiding this comment.
To be slightly bikesheddy, does this read as the local assignment sets the limits, rather than these will be the limits that are passed in via the extremes kwargs to GridHelperCurveLinear below.
I may have been doing too much pytest work recently and am looking for magic everywhere...
Member
Author
There was a problem hiding this comment.
Sounds fair to me! I've changed the wording to 'specify' which should be better
Member
|
👍 I will let the tests run (even though I am pretty sure they are going to fail for un-related reasons). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of comments I think are useful when looking at the demo