Update events handling documentation to work with Python 3.#6354
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom May 1, 2016
Merged
Update events handling documentation to work with Python 3.#6354tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
Member
|
👍 It looks like the docs failure is due to poor version checking in the link checker. |
Member
Author
|
Is the coverage failure messed up? It's talking about changes in coverage that didn't have anything to do with what I changed. |
tacaswell
added a commit
that referenced
this pull request
May 1, 2016
DOC: Update events handling documentation to work with Python 3.
Member
|
backported to v1.5.1-doc as 520d1a1 |
Member
|
I closed and re-opened to re-trigger the builds. I do not know what it's base line is, but it might be looking at the first time it ran this PR vs the second time it ran this PR against a different master. |
QuLogic
modified the milestones:
1.5.2 (Critical bug fix release),
2.1 (next point release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event handling documentation has a lot of Python 2-style print statements, so I have updated them here. I ran the code snippets in Python 3 and they all work. The only difference is that for the Python 3 version, the outputs look like this:
And for Python 2 they look like this now:
They used to not have parens around the outputs, but they do now because of the parens required to make it polyglot code. The old behavior can return if you prepend
from __future__ import print_function, but I don't really think that's necessary.