X Tutup
Skip to content

BLD: make minimum cycler version 0.10.0#6340

Merged
WeatherGod merged 1 commit intomatplotlib:masterfrom
tacaswell:bld_update_cycler_dep
Apr 27, 2016
Merged

BLD: make minimum cycler version 0.10.0#6340
WeatherGod merged 1 commit intomatplotlib:masterfrom
tacaswell:bld_update_cycler_dep

Conversation

@tacaswell
Copy link
Copy Markdown
Member

closes #6325

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Apr 27, 2016
@tacaswell
Copy link
Copy Markdown
Member Author

attn @WeatherGod

I think we did not backport those changes to 2.x so I do not think this needs to be backported either.

@jenshnielsen
Copy link
Copy Markdown
Member

In that case I think 2.x should run the tests with cycler 0.9 on Travis as 1.5.x does

@WeatherGod
Copy link
Copy Markdown
Member

Also need to update setupext.py

@tacaswell
Copy link
Copy Markdown
Member Author

@WeatherGod update what else in setupext.py?

@WeatherGod
Copy link
Copy Markdown
Member

Sorry, let me clarify... in my PR, I updated get_install_requires() so that it returned "cycler>=0.9". I don't know why the diff you have does not reflect that.

@tacaswell
Copy link
Copy Markdown
Member Author

I could not find anything in the code that did any version checking on cycler last night (which confused me). Maybe we lost it in a bad merge?

@WeatherGod
Copy link
Copy Markdown
Member

The faulty PR is #6275. It was backported to 2.x.

@tacaswell
Copy link
Copy Markdown
Member Author

🐑 I forgot to update my local master before forking this branch, stand by.

@tacaswell tacaswell force-pushed the bld_update_cycler_dep branch from 29df8ad to e92eb88 Compare April 27, 2016 13:52
@WeatherGod WeatherGod merged commit 40150b3 into matplotlib:master Apr 27, 2016
@tacaswell tacaswell deleted the bld_update_cycler_dep branch April 27, 2016 15:44
WeatherGod added a commit that referenced this pull request Apr 27, 2016
BLD: make minimum cycler version 0.10.0
@WeatherGod
Copy link
Copy Markdown
Member

backported as 9f83d53

@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.1 (next point release) Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Master requires cycler 0.10.0

5 participants

X Tutup