Add default scatter marker option to rcParams#6328
Merged
tacaswell merged 3 commits intomatplotlib:masterfrom Apr 29, 2016
Merged
Add default scatter marker option to rcParams#6328tacaswell merged 3 commits intomatplotlib:masterfrom
tacaswell merged 3 commits intomatplotlib:masterfrom
Conversation
Contributor
Author
|
The AppVeyor build looks like it failed because it took too long to download freetype. |
Merged
Member
|
Can you also add this key to |
Contributor
Author
|
Alright, done. |
matplotlibrc.template
Outdated
| # installed, may also be `auto` | ||
|
|
||
| ### SCATTER PLOTS | ||
| #scatter.marker # The default marker type for scatter plots. |
bcongdon
force-pushed
the
ft-scatter-marker-rc
branch
from
e87dc6f to
f0dcc36
Compare
Contributor
Author
|
Whoops, my mistake. Fixed. |
Member
|
One more house keeping thing, can you add a note in https://github.com/matplotlib/matplotlib/blob/master/doc/users/whats_new/rcparams.rst documenting this feature? |
Contributor
Author
|
Sure, added that to the docs. |
tacaswell
added a commit
that referenced
this pull request
Apr 29, 2016
Add default scatter marker option to rcParams
Member
|
Thanks! backported to v2.x as ad81e3f I think this is your first contribution to mpl. Congratulations, hopefully we will see you again 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #6272.
Removes hard-coded
'o'as the default marker from within thescatterdefinition. Adds the'scatter.marker'option inrcParams, which is then loaded whenscatteris called.This is my first contribution, so I apologize in advance if I've violated any best practices.