X Tutup
Skip to content

Make checkbuttons with all plotted lines with correct visibility automatically#6310

Merged
QuLogic merged 3 commits intomatplotlib:masterfrom
BTWS2:patch-1
Mar 26, 2017
Merged

Make checkbuttons with all plotted lines with correct visibility automatically#6310
QuLogic merged 3 commits intomatplotlib:masterfrom
BTWS2:patch-1

Conversation

@BTWS
Copy link
Copy Markdown

@BTWS BTWS commented Apr 17, 2016

Previously you had to manually change the variables in func. Now it's done automatically based on the properties of the lines.

…matically

Previously you had to manually change the variables in func. Now it's done automatically based on the properties of the lines.
ax.plot(t, s2, lw=2, color='g', label='6 Hz')
plt.subplots_adjust(left=0.2)

lines = ax.get_lines()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to capture the lines are they are created rather than using ax.get_lines(),

lines = [l0, l1, l2]

@tacaswell
Copy link
Copy Markdown
Member

Except for the use of get_lines 👍 on these changes.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Apr 18, 2016
@dstansby
Copy link
Copy Markdown
Member

Just going to cycle the CI, and then will merge and submit a new PR with the small tweak. Thanks for this improvement @BTWS !

@dstansby dstansby closed this Mar 25, 2017
@dstansby dstansby reopened this Mar 25, 2017
@dstansby dstansby self-assigned this Mar 25, 2017
@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@f859b74). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6310   +/-   ##
========================================
  Coverage          ?   65.4%           
========================================
  Files             ?     267           
  Lines             ?   70081           
  Branches          ?   10000           
========================================
  Hits              ?   45833           
  Misses            ?   21614           
  Partials          ?    2634

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f859b74...0ee87e6. Read the comment docs.

@dstansby dstansby changed the title Make checkbuttons with all plotted lines with correct visibility automatically [MRG+1] Make checkbuttons with all plotted lines with correct visibility automatically Mar 26, 2017
@QuLogic QuLogic changed the title [MRG+1] Make checkbuttons with all plotted lines with correct visibility automatically Make checkbuttons with all plotted lines with correct visibility automatically Mar 26, 2017
@QuLogic QuLogic merged commit 3ba65f1 into matplotlib:master Mar 26, 2017
@dstansby dstansby removed their assignment Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup