Adjust default linewidth to 1.5#6286
Closed
efiring wants to merge 2 commits intomatplotlib:masterfrom
Closed
Conversation
Member
Author
|
It looks like the test failures are all image comparisons involving backend_pgf--that seems odd. |
Member
|
@efiring The pfg backend tests does the image comparison in a slightly odd way so it's not running with the classic style but with the default one |
Member
|
Yeah. 👍 on this (once the PGF baselines are updated). |
Member
|
👍 on this from me as well. |
Member
|
And me too 👍 |
Member
Author
|
Closing and reopening after merging #6290 to trigger the tests again. |
Member
Author
|
Trying again after removing the commit that modified the pgf test files. |
Member
Author
|
I'm stuck; after many tries, I still can't get a mergeable collection of changesets in which the pgf tests pass. |
Member
|
My guess is some mismatch in LaTeX libraries between your machine and Travis. I've had success in the past with this, so I'll give it a go. |
Member
|
Closed by #6300. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default linewidth was changed from 1 to 2.5 for v2.0 in rcsetup, but was given as 2.0 in matplotlibrc.template. Although a fat line can look good for very simple plots, it does not work well for more complex plots. Therefore I recommend a compromise value of 1.5. Regardless of whether this recommendation is accepted, the value in rcsetup needs to match the value in matplotlibrc.template, as it does with this PR.