Merged
Conversation
tacaswell
force-pushed
the
tst_skip_float_rounding_issue_test
branch
from
e37ec17 to
14db594
Compare
Member
Author
|
Bah, this order of the decorators does not work because the failure happens in the outer decorator so barfs on not failing. Ordering the decorators the other order fails on definition. |
Member
|
I think you could just raise |
Member
Author
|
The only downside of that is that the knownfailure could hang around forever, the decorator checks that it actually fails in the cases where it is known to fail |
This test only over passed due to an error arising from a bug in numpy's divmod being fixed (numpy/numpy#6127). See matplotlib#5950
tacaswell
force-pushed
the
tst_skip_float_rounding_issue_test
branch
from
14db594 to
26cba4b
Compare
Member
Author
|
This has un-broken all of our CI. I have it tagged an 1.5.2 to backport it back to 1.5.x (as eventually we will end up with np1.11 in our test for all running branches. |
Member
|
👍 for 1.5.x we likely need to do the same with test_bbox_inches_tight_raster since #6192 wasn't backported onto 1.5.x |
jenshnielsen
added a commit
that referenced
this pull request
Apr 3, 2016
…_test TST: skip broken test
Member
|
Backported to 1.5.x as 44e7356 |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
…ding_issue_test TST: skip broken test
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Aug 13, 2016
Cannot use the decorator for similar reasons as matplotlib#6263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test only over passed due to an error arising from a bug
in numpy's divmod being fixed (numpy/numpy#6127).
See #5950
attn @jenshnielsen