X Tutup
Skip to content

Issue #6105: Adds targetfig parameter to the subplot2grid function#6179

Merged
tacaswell merged 3 commits intomatplotlib:masterfrom
paulkirow:d01f1
Mar 20, 2016
Merged

Issue #6105: Adds targetfig parameter to the subplot2grid function#6179
tacaswell merged 3 commits intomatplotlib:masterfrom
paulkirow:d01f1

Conversation

@paulkirow
Copy link
Copy Markdown
Contributor

As mentioned in issue #6105. A simple implementation. I named the argument targetfig to be consistent with another function in pyplot, subplot_tool.

Feedback needed.



def subplot2grid(shape, loc, rowspan=1, colspan=1, **kwargs):
def subplot2grid(shape, loc, rowspan=1, colspan=1, targetfig=None, **kwargs):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just call it fig.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Mar 18, 2016
@tacaswell
Copy link
Copy Markdown
Member

👍 Just needs documentation in both whats_new and the docstring.

These changes are meant to document the added parameter to the subplot2grid method
tacaswell added a commit that referenced this pull request Mar 20, 2016
ENH: Adds targetfig parameter to the subplot2grid function

closes #6105:
@tacaswell tacaswell merged commit 0003470 into matplotlib:master Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup