Merged
Conversation
| def about(self): | ||
| QtGui.QMessageBox.about(self, "About", | ||
| QtWidgets.QMessageBox.about(self, "About", | ||
| """embedding_in_qt5.py example |
Member
There was a problem hiding this comment.
This line needs to be re-aligned with the opening parentheses above.
Contributor
Author
There was a problem hiding this comment.
Ah, sorry about that. Commit updated. I also removed the now unused import of QtGui.
QMessageBox is in QtWidgets, not QtGui.
Member
|
👍 Thanks |
Member
|
backported to v1.5.1-doc as 20db6a0 |
bearstrong
pushed a commit
to bearstrong/matplotlib
that referenced
this pull request
Apr 1, 2016
Fix about dialog on Qt 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QMessageBox is in QtWidgets, not QtGui.